chore: remove unnecessary shims from viz.py #9765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9765 +/- ##
==========================================
- Coverage 70.81% 70.61% -0.20%
==========================================
Files 586 403 -183
Lines 30445 12598 -17847
Branches 3121 3121
==========================================
- Hits 21559 8896 -12663
+ Misses 8772 3588 -5184
Partials 114 114
Continue to review full report at Codecov.
|
|
Closing this to break up into smaller refactoring tasks prior to final removal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR removes Word Cloud shims from
viz.pythat is now using the new chart data API ( #9710 ) and removes the backend string manipulation logic in Bullet chart that was recently moved tosuperset-ui( apache-superset/superset-ui#440 )TEST PLAN
Local testing
ADDITIONAL INFORMATION
REVIEWERS
@suddjian @rusackas